Fix nvbug6550424: Don't check NVML init behavior on CTK >= 13.4 - #2512
Merged
Conversation
mdboom
added
P0
This comment has been minimized.
This comment has been minimized.
rwgk
approved these changes
Aug 5, 2026
Contributor
|
Is the CI / Build win-64, CUDA 13.3.0 / py3.15 (push) failure merge-blocking now? It thought I saw an intermittent numpy version mixup before, but I see you reran once already. |
rwgk
enabled auto-merge (squash)
August 5, 2026 15:49
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fundamentally, this just skips a test that no longer makes sense on NVML >= 13.4 since the init behavior was changed upstream.
This also refactors the code to move
driver_version_less_thanto a shared helper incuda_python_test_helpers.